Rename wasm_transition to relate to what it actually does #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3rcuriel
requested review from
acmcarther,
damienmg and
mfarrugi
as code owners
|
lgtm, but I don't know how to rerun the buildkite build.. do you mind rebasing to get it to run again? |
|
The build on master was fine, so nevermind that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't actually notice that #240 closed #205, so I figure since the transition literally only deals with transitioning on
proc-macroit should probably be called that.@acmcarther if the reason for it has nothing to do with #205 please ignore this PR.