Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull/expose rustfmt binaries #291

Merged
merged 5 commits into from
Mar 9, 2020
Merged

Pull/expose rustfmt binaries #291

merged 5 commits into from
Mar 9, 2020

Commits on Mar 9, 2020

  1. Fetch and expose the rustfmt binary 

    Pulls in the version of rustfmt that is shipped with Rust 1.39.0.
Distribution path/version found in official release channel TOML. See
http://static.rust-lang.org/dist/channel-rust-1.39.0.toml, and
rust-lang/rust-forge#215 for more information on this.

Relates to bazelbuild#87.
    @colatkinson
    colatkinson committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    82d92b6 View commit details
    Browse the repository at this point in the history

  2. Set LC_ALL in fetch_shas.sh 

    The order of `sort`'s output depends on this variable, and different
users may have it set differently.
    @colatkinson
    colatkinson committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    3f37507 View commit details
    Browse the repository at this point in the history

  3. Add rustfmt hashes to known_shas 

    rustfmt is versioned independently of the other Rust tools, which
necessitates keeping track of its version separately. Binaries are also
not provided for FreeBSD, and so a separate targets list is also used.
    @colatkinson
    colatkinson committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    5e7040b View commit details
    Browse the repository at this point in the history

  4. Expose rustfmt binary via the Rust toolchain

    @colatkinson
    colatkinson committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    420c884 View commit details
    Browse the repository at this point in the history

  5. Add test that rustfmt binary works

    @colatkinson
    colatkinson committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    df47457 View commit details
    Browse the repository at this point in the history