Update proto crates: protobuf to 2.8.2 and grpc-rust to 0.6.2 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the files within //proto/raze/remote are automatically generated by cargo raze. This updates the protobuf crate to 2.8.2, which is as far as we are able to with the most recent version of grpc-rust, which is 0.6.2. The downstream dependencies of grpc-rust required specifying an upper bound on the log 0.4 version, which would otherwise break log 0.3 dependent crates. This should be revisited if grpc-rust is changed or reevaluated for a different default library. This also introduces a patch folder, for patches to be applied by cargo raze. The rationale for patching protobuf is explained in the README, but, in short, circumvents the build.rs file.
damienmg
approved these changes
Apr 22, 2020
colin353
added a commit
to colin353/rules_rust
that referenced
this pull request
Apr 26, 2020
Update proto crates: protobuf to 2.8.2 and grpc-rust to 0.6.2 (bazelbuild#310)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the files within //proto/raze/remote are automatically generated
by cargo raze.
This updates the protobuf crate to 2.8.2, which is as far as we are able
to with the most recent version of grpc-rust, which is 0.6.2. The
downstream dependencies of grpc-rust required specifying an upper bound
on the log 0.4 version, which would otherwise break log 0.3 dependent
crates. This should be revisited if grpc-rust is changed or reevaluated
for a different default library.
This also introduces a patch folder, for patches to be applied by cargo
raze. The rationale for patching protobuf is explained in the README,
but, in short, circumvents the build.rs file.