Support CARGO_BIN_EXE env vars #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
requested review from
acmcarther,
damienmg and
mfarrugi
as code owners
damienmg
approved these changes
Jun 2, 2020
rust/private/rustc.bzl
Outdated
| dst = crate_info.output.path | ||
| if src != dst: | ||
| maybe_rename = " && /bin/mv {src} {dst}".format(src=src, dst=dst) | ||
| command = '{manifest_dir_env}{out_dir_env}{rustc} "$@" --remap-path-prefix="$(pwd)"=__bazel_redacted_pwd{maybe_rename}'.format( |
There was a problem hiding this comment.
This line is long, maybe use a triple quoted string?
There was a problem hiding this comment.
Reverted away from the the fstring-like templates
This emulate's Cargo's behavior. Unfortunately just setting -o instead of --out-dir warns with the following (even if only one output is being built): ``` warning: due to multiple output types requested, the explicitly specified output file name will be adapted for each output type ```
These env vars point at the binaries of data dependencies. See https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates
illicitonion
force-pushed
the
test-env-var
branch
from
91d661a
to
b5652ef
Compare
damienmg
approved these changes
Jun 2, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.43 cargo will set
CARGO_BIN_EXE-prefixed env vars for each binary your crate depends on, so you can access them in integration tests.Also, output binary names with the same name as the target, rather than replacing
-s with_s, to better emulate how Cargo works.