Expose futures library from proto/raze #324
Closed
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot that this file is autogenerated. I'll do this the correct way |
|
Thanks @colin353, I'll close this PR if you wish to reuse it for the proper change, feel free to reopen and ping me then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we expose
protobufandgrpcfrom proto/raze, so that dependencies can import them via targets like@io_bazel_rules_rust//proto/raze:grpc. But to use the full grpc library, e.g. with streaming grpc, we also need to import traits from thefutureslibrary thatgrpcis built against. That's not possible though, since it's not exported here.By making futures visible, it means that dependencies can just add
@io_bazel_rules_rust//proto/raze:futuresas a dependency to make this work.