Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rustc_compile_action #330

Merged
merged 5 commits into from
Jun 13, 2020
Merged

Refactor rustc_compile_action #330

merged 5 commits into from
Jun 13, 2020

Commits on Jun 10, 2020

  1. Refactor rustc_compile_action 

    Functionally, this code should be identical.

However, it (hopefully) is easier to read, and makes
subcomponents of the rustc command (parsing args, env, etc)
easier to generalize.
    @smklein
    smklein committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    53e2f67 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. Avoid unnecessary '!= None'

    @smklein
    smklein committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    6eb60f8 View commit details
    Browse the repository at this point in the history

  2. refactor adding out dir to new function

    @smklein
    smklein committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    9724d5e View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2020

  1. Respond to mfarrugi's feedback

    @smklein
    smklein committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    851c0bb View commit details
    Browse the repository at this point in the history

  2. merge

    @smklein
    smklein committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    ce354af View commit details
    Browse the repository at this point in the history