Deprecate out dir tar #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelmansouri
reviewed
Jun 29, 2020
jelmansouri
reviewed
Jun 29, 2020
illicitonion
approved these changes
Jun 29, 2020
This attribute force the usage of tar as part of the build which is problematic for various platform. Instead of adding support for it in native format, just remove this one as we have the `cargo_build_script` rule.
damienmg
force-pushed
the
deprecate_out_dir_tar
branch
from
1502108
to
393276c
Compare
dfreese
approved these changes
Jun 30, 2020
smklein
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute force the usage of tar as part of the build which
is problematic for various platform. Instead of adding support
for it in native format, just remove this one as we have
the
cargo_build_scriptrule.Depends on #359
/cc @jelmansouri @illicitonion