Pass extraneous environment variables to build scripts #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
approved these changes
Jun 30, 2020
cargo-raze has `buildrs_additional_environment_variables` which allows extraneous environment variable to be passed to the build script. In addition this should enable for everybody to add the environment variables that are not added by the `cargo_build_script` rule itself. That's the rules_rust side of the fix for google/cargo-raze#179.
damienmg
force-pushed
the
cargo_build_script
branch
from
f02e4b8
to
de2d8af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo-raze has
buildrs_additional_environment_variableswhich allowsextraneous environment variable to be passed to the build script. In addition
this should enable for everybody to add the environment variables that are
not added by the
cargo_build_scriptrule itself.That's the rules_rust side of the fix for google/cargo-raze#179.