fix: Download llvm tools for nightly builds after 2020-05-22 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienmg
reviewed
Jul 2, 2020
damienmg
approved these changes
Jul 2, 2020
Co-authored-by: Damien Martin-Guillerez <damienmg@users.noreply.github.com>
|
I went ahead and committed your suggestion. Would it be possible to get this merged today? |
dfreese
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After nightly Rust builds after 2020-05-22 do not have the
libLLVM-10-*version*-nightly.sodylib included with the normal rust-nightly gzip due to rust-lang/rust#70838. Therefore, nightly builds after this date need to download and extract the llvm-tools gzip to ensure this dylib is available.