Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rustdoc path in rustdoc_test with --nolegacy_external_runfiles option #374

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

oxidase
Copy link
Contributor

@oxidase oxidase commented Jul 18, 2020

Using File.path breaks builds with --nolegacy_external_runfiles option
as the gnerated script has use external/rust/bin/rustdoc that
referrers to legacy runfiles and File.short_path uses ../rust/bin/rustdoc

…tion

Using File.path breaks builds with --nolegacy_external_runfiles option
as the gnerated script has use `external/rust/bin/rustdoc` that
referrers to legacy runfiles and File.short_path uses `../rust/bin/rustdoc`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@oxidase
Copy link
Contributor Author

oxidase commented Jul 18, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@damienmg damienmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damienmg damienmg merged commit af00ec9 into bazelbuild:master Jul 20, 2020
@damienmg
Copy link
Collaborator

Thanks!

jelmansouri pushed a commit to jelmansouri/rules_rust that referenced this pull request Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants