Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustfmt windows fixes #376

Merged
merged 17 commits into from
Jul 26, 2020
Merged

Conversation

jelmansouri
Copy link
Contributor

This is on top of the process wrapper change, see bindgen/bindgen.bzl and test/rustfmt/rustfmt_generator.bzl.

Copy link
Collaborator

@dfreese dfreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though can this be updated or rebased to master?

@jelmansouri
Copy link
Contributor Author

Updated with the master! Thanks!

@dfreese dfreese merged commit 7004ca3 into bazelbuild:master Jul 26, 2020
@dfreese
Copy link
Collaborator

dfreese commented Jul 26, 2020

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants