Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate dependencies of examples in the top level workspace #407

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Removed duplicate dependencies of examples in the top level workspace #407

merged 3 commits into from
Sep 24, 2020

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Sep 15, 2020

This PR adds rust_workspace which is meant to define transitive dependencies as well as cleans up some duplicate files that were in the root of the project but only used by examples.

Updated documentation

Note the updated documentation in docs/index.md

Added bazel_skylib to rust_repositories

It appears there are some uses of bazel_skylib within these rules but there aren't really any guarantees that that repository is available. This may be my fault with the changes made in #399 to @io_bazel_rules_rust//rust/platform:platform.bzl but I feel the bazel_skylib dependency should be conditionally added

Added rust_workspace

I feel this is much nicer on the users's end as it gives them a single place to go to look at dependencies and is nicer on the repo because it means dependencies can more easily updated. I'm not the biggest fan of the name rust_workspace so if this was an acceptable concept, I'm happy to take suggestions on what the name should be called.

@UebelAndre
Copy link
Collaborator Author

Is renovate.json still used?

@UebelAndre
Copy link
Collaborator Author

@damienmg Hey, if you get a moment do you think you could check out this PR? 🙏

@damienmg
Copy link
Collaborator

LGTM.

@damienmg damienmg merged commit 5998baf into bazelbuild:master Sep 24, 2020
@UebelAndre UebelAndre deleted the workspace-structure branch September 24, 2020 12:51
@UebelAndre
Copy link
Collaborator Author

@damienmg i think you'll need to make a new release and update the docs since rust_workspace isn't in that version in the docs 😞

@damienmg
Copy link
Collaborator

Updating the doc is a PR, mind sending one? You just need to run the shellscript. There is no real release on this repository otherwise.

@UebelAndre
Copy link
Collaborator Author

Is renovate.json still used?

@damienmg Also, do you know the answer to this question?

@damienmg
Copy link
Collaborator

I don't think it ever worked, @nlopezgi might have more insights.

@nlopezgi
Copy link
Contributor

I don't think it ever worked, @nlopezgi might have more insights.

iirc (but my memory is fuzzy) It did work for a bit (i do remember we had it for rules_docker and rules_k8s), but then was turned off and/or replaced by some other solution (one provided by Bazel CI, iirc?). But renovate bot has likely not been in use for some time if it ever was used at all.

@UebelAndre
Copy link
Collaborator Author

@nlopezgi @damienmg Do you see any value in keeping that there? Or would you like me to open a PR to remove it?

@damienmg
Copy link
Collaborator

damienmg commented Sep 25, 2020 via email

@UebelAndre UebelAndre mentioned this pull request Sep 25, 2020
@illicitonion illicitonion mentioned this pull request May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants