-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed duplicate dependencies of examples in the top level workspace #407
Conversation
Is renovate.json still used? |
@damienmg Hey, if you get a moment do you think you could check out this PR? 🙏 |
LGTM. |
@damienmg i think you'll need to make a new release and update the docs since |
Updating the doc is a PR, mind sending one? You just need to run the shellscript. There is no real release on this repository otherwise. |
@damienmg Also, do you know the answer to this question? |
I don't think it ever worked, @nlopezgi might have more insights. |
iirc (but my memory is fuzzy) It did work for a bit (i do remember we had it for rules_docker and rules_k8s), but then was turned off and/or replaced by some other solution (one provided by Bazel CI, iirc?). But renovate bot has likely not been in use for some time if it ever was used at all. |
This can be deleted, a PR would be welcomed :)
…On Thu, Sep 24, 2020 at 9:56 PM UebelAndre ***@***.***> wrote:
@nlopezgi <https://github.com/nlopezgi> @damienmg
<https://github.com/damienmg> Do you see any value in keeping that there?
Or would you like me to open a PR to remove it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#407 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4MO76BZKTD2CIMKLCZ6ODSHOP5VANCNFSM4RNT7U4Q>
.
|
This PR adds
rust_workspace
which is meant to define transitive dependencies as well as cleans up some duplicate files that were in the root of the project but only used by examples.Updated documentation
Note the updated documentation in docs/index.md
Added
bazel_skylib
torust_repositories
It appears there are some uses of
bazel_skylib
within these rules but there aren't really any guarantees that that repository is available. This may be my fault with the changes made in #399 to @io_bazel_rules_rust//rust/platform:platform.bzl but I feel thebazel_skylib
dependency should be conditionally addedAdded
rust_workspace
I feel this is much nicer on the users's end as it gives them a single place to go to look at dependencies and is nicer on the repo because it means dependencies can more easily updated. I'm not the biggest fan of the name
rust_workspace
so if this was an acceptable concept, I'm happy to take suggestions on what the name should be called.