Addressed additional Buildifier defects #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@mfarrugi Do you have time today to take a look at this one? |
mfarrugi
requested changes
Oct 13, 2020
mfarrugi
reviewed
Oct 13, 2020
|
lgtm, sans ci errors |
|
@mfarrugi updated! Sorry, I accidentally dropped one of the commits in my last push. Fortunately, it was just a cherry-pick from another branch 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change takes more out of #420 and addresses some buildifier defects and structural inconsistencies.
The way docs and examples had their
WORKSPACEsetup didn't fully rely onio_bazel_rules_rustto provide all it's dependencies. This has now been updated. The only thing required to userules_rustis to callrust_repositoriesandrust_workspacein your WORKSPACE which is now demonstrated within the project.I apologize for this PR being larger than I'd like. A lot of this was pulled out of #420. Going forward, it should be easier to make each commit represent a fixed buildifier defect.