Regenerate bindgen raze outputs #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's worth noting that this PR is intentionally not updating the version of |
mfarrugi
approved these changes
Oct 15, 2020
|
|
||
| [dependencies] | ||
| bindgen = "0.54.0" | ||
| libloading = "=0.5.0" |
There was a problem hiding this comment.
It was being manually loaded in a56490d#diff-559b24b793c89733f91d4e6a1cdb1af7785f20e4748b4b40e59e68163016260cL33-L45
This seems like error initially since the block
[raze.crates.libloading.'0.5.2']
additional_deps = [":global_static"]
additional_build_file = "libloading-global-static.BUILD"was trying to set dependencies for libloading.'0.5.2' when in fact this version was never being specified anywhere. Raze would give a warning about this and then the BUILD file would setup raze__libloading__0_5_0.
By adding this dependency to the Cargo.toml file, this allows raze to correctly pull and setup the dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regenerates the bindgen raze outputs using
cargo-razeversion0.6.0.Notably, this change changes the
gen_workspace_prefixtorules_rust_bindgenso users of these rules also usingrazedon't run into conflicts in the targets they expected to be using vs the targetsrules_rustis providing.