Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable buildifier for CI #440

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Enable buildifier for CI #440

merged 2 commits into from
Oct 15, 2020

Conversation

UebelAndre
Copy link
Collaborator

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 15, 2020
@UebelAndre
Copy link
Collaborator Author

@damienmg @mfarrugi Any assistance in solving for these warnings would be greatly appreciated! 🙏

I think it'd be really good for the repo to have buildifier enabled 😅

@mfarrugi
Copy link
Collaborator

mfarrugi commented Oct 15, 2020 via email

@UebelAndre
Copy link
Collaborator Author

I opened #443 and #442 to track things I feel really should be solved

@UebelAndre
Copy link
Collaborator Author

I also opened #441 to solve for additional defects not caught in CI (I believe this is due to how the example's workspaces are setup)

@UebelAndre UebelAndre marked this pull request as ready for review October 15, 2020 19:51
@mfarrugi mfarrugi merged commit 9279938 into bazelbuild:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants