Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add buildscript link flags only to parent crate #448

Merged
merged 2 commits into from
Oct 23, 2020
Merged

add buildscript link flags only to parent crate #448

merged 2 commits into from
Oct 23, 2020

Commits on Oct 16, 2020

  1. add test demonstrating link flags causing downstream crate compile fail

    @dae
    dae committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    1a25ac0 View commit details
    Browse the repository at this point in the history

  2. add buildscript link flags only to parent crate 

    On Windows, an -lalias:real link flag will cause an error when used
by a crate that does not link to the underlying library. This is
triggered when compiling a rust_library that has pyo3 as a dependency
on Windows.
    @dae
    dae committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    457a49b View commit details
    Browse the repository at this point in the history