-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update shebang to use env #46
Update shebang to use env #46
Conversation
I would consider this strictly more portable, is this blocked for any other reasons? |
The main maintainers are clearly inactive(a year or over an year). @acmcarther If you are willing to become a maintainer, can you please ask to be added to the group( bazel-discuss@googlegroups.com )? |
Sorry for the wait. I have been the sole maintainer of this during my spare time, and due to commitments from my regular work and family commitments that have come up, I have not had much time to commit to this. I have reached out to seek new maintainers, and @acmcarther, @mhlopko, and two others have graciously agreed to take up maintainership of rules_rust. I will help with getting the existing PR's committed and will then take on a more advisory role, focusing on helping the new maintainers get up to speed on the project and answering any questions they may have. @acmcarther This change looks good to me. Can you rebase and then go ahead and merge? Thanks! |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
ee7d38b
to
877531f
Compare
Error was caused by a bad rebase that scooped in changes. I undid the rebase, re authored the commit, and force pushed. Reviewing test failure now. |
877531f
to
30d8e0c
Compare
Test failure was elsewhere. Will merge with dzc's blessing in |
Sorry to be late in the party, I think this could be rewritten to use https://docs.bazel.build/versions/master/skylark/lib/actions.html#run_shell and get the same bash location as other rules in bazel are using. |
This PR replaces "/bin/bash" with the more general "/usr/bin/env bash". This is necessary on platforms that don't have
bash
in/bin
, namely BSD and esoteric linux distributions such as Guix and NixOS.FWIW: This is a pervasive problem is Bazel. My own build rules for Bazel apply a multi thousand line patch just to let Bazel build on NixOS. I'm OK with this PR being closed if you feel this is too much of a niche problem.