Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aarch64 support #465

Merged
merged 1 commit into from
Oct 24, 2020
Merged

add aarch64 support #465

merged 1 commit into from
Oct 24, 2020

Conversation

lizan
Copy link
Contributor

@lizan lizan commented Oct 24, 2020

Signed-off-by: Lizan Zhou lizan@tetrate.io

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@google-cla google-cla bot added the cla: yes label Oct 24, 2020
Comment on lines +86 to +97
rust_repository_set(
name = "rust_linux_aarch64",
exec_triple = "aarch64-unknown-linux-gnu",
extra_target_triples = ["wasm32-unknown-unknown"],
version = version,
iso_date = iso_date,
rustfmt_version = rustfmt_version,
edition = edition,
dev_components = dev_components,
sha256s = sha256s,
)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Generally good with everything in the PR, but a little hesitant to have this function now pull 4 toolchains when most folks need 1 of these, sometime 2. I'd generally encourage calling rust rust_repository_set explicitly.

Is there a pattern of usage that you're seeing?

Perhaps this function could become more generally useful if the exec_triple's called were a parameter?

# maintain backwards compatibility
if exec_triples is None:
    exec_triples = [
        "rust_linux_x86_64",
        "rust_darwin_x86_64,
        "rust_freebsd_x86_64",
        "rust_windows_x86_64",
    ]

for exec_triple in exec_triples:
    rust_repository_set(
        name = "rust_linux_aarch64",
        exec_triple = exec_triple,
        extra_target_triples = ["wasm32-unknown-unknown"],
        version = version,
        iso_date = iso_date,
        rustfmt_version = rustfmt_version,
        edition = edition,
        dev_components = dev_components,
        sha256s = sha256s,
    )

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the toolchains lazily fetched?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah. Good point.

@dfreese dfreese merged commit 9c889b0 into bazelbuild:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants