Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct CARGO_MANIFEST_DIR values for Bazel <3.7.0 #469

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Correct CARGO_MANIFEST_DIR values for Bazel <3.7.0 #469

merged 1 commit into from
Nov 3, 2020

Commits on Oct 30, 2020

  1. Correct CARGO_MANIFEST_DIR values for Bazel <3.7.0 

    Bazel 3.7.0 introduced a change (301b96b223b0c0) in the way it reports
file paths for external packages. This ensures that rules_rust sets the
right value for CARGO_MANIFEST_DIR both for Bazel < 3.7.0 and >= 3.7.0.

Note that if this changed once, it might change again, so the right
thing to do is to use a bazel API to do that work once it's available.
    @sitaktif
    sitaktif committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    29b1783 View commit details
    Browse the repository at this point in the history