Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix root detection in clippy for bin crates #504

Merged
merged 2 commits into from
Nov 25, 2020

Conversation

djmarcin
Copy link
Contributor

Prior to this PR, bin crates with more than one file in srcs would fail with this error:

$ bazel build --aspects=@io_bazel_rules_rust//rust:rust.bzl%rust_clippy_aspect --output_groups=clippy_checks //...
INFO: Invocation ID: c3647be4-e5fe-4f90-a1a4-c9a84c17c45c
ERROR: /home/user/repo/BUILD:5:12: in @io_bazel_rules_rust//rust:private/clippy.bzl%rust_clippy_aspect aspect on rust_binary rule //foo:bar:
Traceback (most recent call last):
        File ".../io_bazel_rules_rust/rust/private/clippy.bzl", line 53, column 26, in _clippy_aspect_impl
                root = crate_root_src(ctx.rule.attr, srcs = rust_srcs)
        File ".../io_bazel_rules_rust/rust/private/rust.bzl", line 115, column 13, in crate_root_src
                fail("No {} source file found.".format(" or ".join(file_names)), "srcs")
Error in fail: attribute srcs: No lib.rs or bar.rs source file found.
ERROR: Analysis of aspect '@io_bazel_rules_rust//rust:rust.bzl%rust_clippy_aspect of //foo:bar' failed; build aborted: Analysis of target '//foo:bar' failed

@google-cla
Copy link

google-cla bot commented Nov 25, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 25, 2020
@djmarcin
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Nov 25, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@dfreese dfreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

If you're feeling ambitious, it looks like it would make more sense to pass in the crate_info.type into crate_root_src, instead of file_name, since this is showing up elsewhere:

root = crate_root_src(ctx.attr, ctx.files.srcs, file_name = "main.rs"),

@djmarcin
Copy link
Contributor Author

Sure, I'll give that a look. I signed the CLA for my company, but it looks like that takes a few days to get approved, so I guess I've got time. 😂

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 25, 2020
@djmarcin
Copy link
Contributor Author

@dfreese Updated to pass type to crate_root_src instead, and the CLA is good to go as well.

@dfreese dfreese merged commit feb8642 into bazelbuild:master Nov 25, 2020
@dfreese
Copy link
Collaborator

dfreese commented Nov 25, 2020

Thanks!

@djmarcin djmarcin deleted the clippy-bin branch February 16, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants