-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix root detection in clippy for bin crates #504
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
If you're feeling ambitious, it looks like it would make more sense to pass in the crate_info.type into crate_root_src, instead of file_name, since this is showing up elsewhere:
rules_rust/rust/private/rust.bzl
Line 204 in afee872
root = crate_root_src(ctx.attr, ctx.files.srcs, file_name = "main.rs"), |
Sure, I'll give that a look. I signed the CLA for my company, but it looks like that takes a few days to get approved, so I guess I've got time. 😂 |
@dfreese Updated to pass type to crate_root_src instead, and the CLA is good to go as well. |
Thanks! |
Prior to this PR, bin crates with more than one file in srcs would fail with this error: