Update rules_rust to use Bazel's toolchains feature. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows rust targets to only depend on (and thus download) the toolchains that are used, dynamically chosen based on the current target platform. Fixes #14.
damienmg
approved these changes
Aug 28, 2017
There was a problem hiding this comment.
Awesome, this is exciting! Please let @davidzchen chime in.
|
@davidzchen Do you have time to review this, and do you have an opinion of the fact that it requires the latest Bazel? Should we cut a release of rules_rust before merging this, for people who haven't upgraded to use? |
|
Sorry for the delay. This looks great. Thanks, John! |
davidzchen
approved these changes
Sep 27, 2017
ittaiz
reviewed
Nov 9, 2017
| return f | ||
| return input | ||
|
|
||
| def _get_files(input): |
There was a problem hiding this comment.
this and _get_first_file seem like good candidates for skylib cc @laurentlb
acmcarther
added a commit
to acmcarther/rules_rust
that referenced
this pull request
Jan 20, 2018
* Make rule tests compatible with the new string representations in Skylark (bazelbuild#51) * Rename set to depset (bazelbuild#50) * Update rules_rust to use Bazel's toolchains feature. (bazelbuild#52) This allows rust targets to only depend on (and thus download) the toolchains that are used, dynamically chosen based on the current target platform. Fixes bazelbuild#14. * Sketch of dylib support * Update compiler toolchain to 1.20.0. (bazelbuild#56) * Fix transitive dylib support. * Fix 'data' field not being made available to rust_test rule. * Topological sort for dylib link flags * Tidy rpath fn * Fix linking transitive static libs, and dylib ordering. * Actually export rust_library.dynamic_libs * Make sure TMPDIR exists for rustc. * Properly include dynamic_libs in runfiles. * fix syntax errors * more * Add support for depending on shared libraries on linux. * Merge raze patches into dylibs branch. * Fixup merge, including remove broken ctx.file.out_dir_tar from doc_* rules. * look for native deps when only transitive * deduplicate rpaths * hackily fix .so symlink..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows rust targets to only depend on (and thus download) the
toolchains that are used, dynamically chosen based on the current target
platform.
This requires use of Bazel 0.5.4, and will not work with earlier releases of Bazel.
Fixes #14.