Updated minimum supported version from 3.0.0 to 3.4.0 #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general, I think the minimum version of 3.0.0 was too aggressive, and I'm looking at moving that backward, so I'm not comfortable with this at the moment. |
|
Just calling this out as a requisite of another change. Though I personally think that moving to 4.0 as a min supported version is fine. I hate that there are no releases for this repo and it feels extremely nebulous as to what state the rules are in between different commits. Since 4.0 is a LTS release, it'd at least communicate at what point the rules will work, regardless of what revision they're at. |
|
But yeah, not waiting on this change by any means so no pressure to merge. |
|
@dfreese what was the change that required 3.0 again? |
|
Closing this since I closed #519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks #519 since it introduces the use of
incompatible_use_toolchain_transitionwhich was only added in3.4.0(bazelbuild/bazel@099cf2f)Also, version bumps should be their own commits so they're more discoverable IMO.