Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change test for greet method, instead of greeting #533

Merged
merged 1 commit into from
Dec 14, 2020
Merged

fix: change test for greet method, instead of greeting #533

merged 1 commit into from
Dec 14, 2020

Conversation

diohabara
Copy link
Contributor

This PR is related to #482.

I fixed a minor mistakes in the sample code.

illicitonion
illicitonion approved these changes Dec 14, 2020
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion
Copy link
Collaborator

@dfreese @mfarrugi @damienmg Any idea why CLA Bot isn't kicking in? Can one of you give it a nudge?

@damienmg
Copy link
Collaborator

@googlebot

@google-cla google-cla bot added the cla: yes label Dec 14, 2020
@illicitonion illicitonion merged commit 4b2a744 into bazelbuild:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diohabara @illicitonion @damienmg