Allow rustc env vars to be set in files #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
rustc_env_file
branch
2 times, most recently
from
2b436fa
to
a31ef26
Compare
hlopko
reviewed
Feb 2, 2021
|
Oh we actually already have a |
illicitonion
force-pushed
the
rustc_env_file
branch
2 times, most recently
from
b9b7c3a
to
ff47cf3
Compare
Build scripts are executed in the exec configuration, not the target configuration, which means it's currently impossible to use values which were generated as a result of the `--stamp` flag when creating a `rust_binary`. This means that embedding things like build timestamps, git shas, and dynamic version numbers, is impossible. This change allows you to depend, in the target configuration (because no transition occurs on the attribute) on the output of a genrule which consumes data from the stable and volatile workspace status commands.
illicitonion
force-pushed
the
rustc_env_file
branch
from
ff47cf3
to
b694a3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build scripts are executed in the exec configuration, not the target
configuration, which means it's currently impossible to use values which
were generated as a result of the
--stampflag when creating arust_binary. This means that embedding things like build timestamps,git shas, and dynamic version numbers, is impossible.
This change allows you to depend, in the target configuration (because
no transition occurs on the attribute) on the output of a genrule which
consumes data from the stable and volatile workspace status commands.