Updated some hand edited cargo-raze outputs #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfarrugi
reviewed
Jan 21, 2021
mfarrugi
approved these changes
Jan 21, 2021
|
Thanks @mfarrugi you're a hero! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the release of
cargo-raze 0.9.0, it can now add targets to thedataattribute of cargo_build_script targets. This means some hand edited build files can be updated to be regenerated via normal reruns ofcargo-raze. The only outstanding issue is there's no mechanism forcargo-razeto write the links attribute in generated BUILD files. This work is tracked by google/cargo-raze#344 in that project.