rules_rust: make it possible to use non-staticlib rust_library targets in c++ deps #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
reviewed
Feb 24, 2021
hlopko
reviewed
Feb 24, 2021
hlopko
reviewed
Feb 24, 2021
My editor is configured to clean up trailing whitespace, and I'm tired of having to back out these changes when I commit.
…s in c++ deps ld can handle .rlib archives, since they're really just standard ar(1) archives like a .a file with some extra metadata. As a result, we can avoid using staticlib crates when building mixed C++/Rust binaries. This doesn't correctly handle libstd et al (yet), or deal with some generated symbols that rustc produces when it drives the linking step, but it's a start.
On most platforms the default output from rustc is PIC code[0], so this should be safe. 0: https://doc.rust-lang.org/rustc/codegen-options/index.html#relocation-model
hlopko
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ld can handle .rlib archives, since they're really just standard ar(1)
archives like a .a file with some extra metadata. As a result, we can avoid
using staticlib crates when building mixed C++/Rust binaries.
This doesn't correctly handle libstd et al (yet), or deal with some generated
symbols that rustc produces when it drives the linking step, but it's a start.