Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -L but not -l to rlib compilations #607

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

illicitonion
Copy link
Collaborator

Build scripts may add -l flags to dependees, and without the relevant -L
flags those -l flags may fail to resolve, causing build failures.

@illicitonion
Copy link
Collaborator Author

#576 removed both the -L and -l flags, this just re-adds the -L ones.

Copy link
Member

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with updating the tests), thank you for re-fixing this :)

test/unit/native_deps/native_deps_test.bzl Show resolved Hide resolved
Build scripts may add -l flags to dependees, and without the relevant -L
flags those -l flags may fail to resolve, causing build failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants