Add -Lnative flags for C++ runtime library #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah tests for this are one big yak shave for which I'm not sure I'm prepared for mentally :)) It would involve setting up a custom C++ toolchain that uses static_runtime_lib and actually work on our (at least) Linux CI workers. I'd reuse Bazel's autoconfiguration logic, but I'd need to be able to be able to customize it with the runtime lib, which needs Bazel PRs. And then writing a rule that would transition to this custom toolchain for the unit test. |
hlopko
force-pushed
the
add_runtime_lib_dir
branch
from
145b332
to
9ee759a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been a part of #576.