The default wasm-bindgen toolchain can now optionally be registered #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@illicitonion Hey, do you have a second to take a look here? 🙏 |
illicitonion
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it to be the common case that users will want to register their own
rust_wasm_bindgen_toolchainsince they'll be writing code with their own set of crate dependencies and would otherwise be limited to the version ofwasm-bindgenused in the default toolchain. This PR should make it clearer and easier for users looking to setup their own toolchain.Notable changes in this PR:
register_default_toolchaintorust_wasm_bindgen_repositoriesrules_nodejsfrom3.1.0to3.2.2to pick up a few bug fixes.providers.bzlfile for easy access to whatrust_wasm_bindgenreturns