-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved crate_universe into it's own directory #651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
integration.rs will need a couple of changes to some hard-coded strings, too
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
@illicitonion I cannot find what you're referring to in the test. They feel quite unmaintainable IMO and would opt to silence it for now. I feel the very next thing that should be done is to update the output to be a well formed, pre-rendered, json file or something. #653 |
Yeah, I agree :) I'm about to send out a PR with some smaller, much more targeted tests (though they don't fully replace the integration tests yet). FWIW the reason that the existing test is failing is because someone released a new version of |
#654 😄 |
Given that there is support for interfacing with this rule without any
Cargo.toml
files, I would say it's not a "cargo" tool and should go elsewhere. It may still use cargo under the hood but I don't think this is relevant enough to warrant this rule living in./cargo
.This PR moves the
crate_universe
rule into it's own directory andworkspace.bzl
has been renamed todefs.bzl
to be consistent with./rust