Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated crate_universe dependencies #656

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Updated crate_universe dependencies #656

merged 2 commits into from
Mar 30, 2021

Conversation

UebelAndre
Copy link
Collaborator

This PR updates the resolver to use a version of cargo-raze which does not require any dependencies from the binary_deps feature. This should make it much easier and faster to compile.

The upstream PR is google/cargo-raze#407

@google-cla google-cla bot added the cla: yes label Mar 29, 2021
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with depending on a fork of cargo-raze for a bit, hopefully we can get back onto a release soon :)

crate_universe/Cargo.toml Outdated Show resolved Hide resolved
@UebelAndre
Copy link
Collaborator Author

@illicitonion any idea what's going on with the CLA?

@UebelAndre
Copy link
Collaborator Author

@illicitonion seems like the CLA issue is resolved.

@illicitonion illicitonion merged commit 8fa205e into bazelbuild:main Mar 30, 2021
@UebelAndre UebelAndre deleted the deps branch March 30, 2021 13:16
yagehu pushed a commit to yagehu/rules_rust that referenced this pull request Apr 23, 2021
This PR updates the resolver to use a version of `cargo-raze` which does not require any dependencies from the `binary_deps` feature. This should make it much easier and faster to compile.

The upstream PR is google/cargo-raze#407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants