Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed BUILD and WORKSPACE files to BUILD.bazel and WORKSPACE.bazel #665

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Conversation

UebelAndre
Copy link
Collaborator

The use of BUILD/WORKSPACE vs BUILD.bazel/WORKSPACE.bazel was inconsistent across the repo. This PR updates all files without the .bazel extension to use it (which has the higher priority over the two styles. see here).

Additionally, this PR contains buildifier fixes

@google-cla google-cla bot added the cla: yes label Mar 30, 2021
@UebelAndre UebelAndre marked this pull request as ready for review March 30, 2021 20:18
@hlopko
Copy link
Member

hlopko commented Mar 31, 2021

Funny story, we relied on the existing naming of these files - files without .bazel extension were used by blaze (our internal build of bazel) and files with .bazel were ignored.

But I understand the consistency argument, and it's on us to fix our undocumented assumptions internally. I would have chosen files without extension (support for .bazel suffix was added for repos that need to build with bazel and buck at the same time, which is not the case for rules_rust). But we use raze and there I could be convinced to generate files with the suffix, and then to be consistent we need suffices. So shrug :)

@UebelAndre
Copy link
Collaborator Author

I was not aware of any use cases with Blaze nor did I think these rules could be used with Buck. Is any of that documented somewhere? I definitely wasn't trying to break anyone with this change.

@fweikert
Copy link
Member

@UebelAndre how did you invoke Buildifier? I'm trying to understand why the formatting problems weren't caught on CI.

@UebelAndre
Copy link
Collaborator Author

UebelAndre commented Mar 31, 2021

@fweikert From the root of the repo, I ran

buildifier -lint=fix -mode=fix -warnings=all -r ./

and I'm using

buildifier version: 3.5.0
buildifier scm revision: 10384511ce98d864faf064a8ed54cdf31b98ac04

@fweikert
Copy link
Member

fweikert commented Apr 1, 2021

Ok, thank you! bazelbuild/continuous-integration#1129 should fix Buildifier problems on CI.

yagehu pushed a commit to yagehu/rules_rust that referenced this pull request Apr 23, 2021
…azelbuild#665)

The use of `BUILD`/`WORKSPACE` vs `BUILD.bazel`/`WORKSPACE.bazel` was inconsistent across the repo. This PR updates all files without the `.bazel` extension to use it (which has the higher priority over the two styles. see [here](https://docs.bazel.build/versions/master/build-ref.html#packages)).

Additionally, this PR contains buildifier fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants