Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commit and push step of actions #686

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

illicitonion
Copy link
Collaborator

We need to work out how users should consume these binaries, but for now
this reliably fails so let's stop doing it.

Instead, cat out what the the contents of the generated file would
be, for easy copy and paste by people working on the rules.

We need to work out how users should consume these binaries, but for now
this reliably fails so let's stop doing it.

Instead, `cat` out what the the contents of the generated file _would_
be, for easy copy and paste by people working on the rules.
@UebelAndre
Copy link
Collaborator

UebelAndre commented Apr 8, 2021

I'm still not convinced this is a bad thing to do. This is the reality of having a rust binary being used in a repository rule. Instead of removing it I'd like to discuss alternatives.

I'd ask @dfreese for some input since he originally raised concerns.

@illicitonion
Copy link
Collaborator Author

I'm still not convinced this is a bad thing to do. This is the reality of having a rust binary being used in a repository rule. Instead of removing it I'd like to discuss alternatives.

I'd ask @dfreese for some input since he originally raised concerns.

We should definitely have a discussion about alternatives (and we may re-add this code as a result), but for now we have code which we know is broken (because of permissions issues), and has had reasonable objections raised about it being problematic if it were to start working, so let's remove it while we have that discussion :)

@illicitonion illicitonion merged commit 1371c91 into bazelbuild:main Apr 8, 2021
@illicitonion illicitonion deleted the remove-commit-and-push branch April 8, 2021 16:46
yagehu pushed a commit to yagehu/rules_rust that referenced this pull request Apr 23, 2021
We need to work out how users should consume these binaries, but for now
this reliably fails so let's stop doing it.

Instead, `cat` out what the the contents of the generated file _would_
be, for easy copy and paste by people working on the rules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants