-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for header_templates in generated docs #706
Conversation
Mechanically this seems reasonable, but I don't really know stardoc or anything about our documentation situation, so I'll leave for others to weigh in :) |
I'll ask David. I figured you'd be a good reviewer since you had just reviewed the crate universe docs PR. But I realize that wasn't a change to docs generation 😅 |
Will try and take a look at this this evening. |
For a bit of extra context, I'm wanted this functionality to be able to add something like https://github.com/UebelAndre/rules_rust/blob/docs/docs/rust_analyzer.md If we can have custom headers then we can add more contextual documentation about rules there, keep the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, family stuff took precedence.
Generally looks fine to me. One question.
@dfreese ready for another review |
Changes
Rust Rules