Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run basic crate_universe example on Windows #712

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

illicitonion
Copy link
Collaborator

@illicitonion illicitonion commented Apr 27, 2021

We already disable all sys crates from our tests, so this is keeping in
that fashion. Looks like the issues here aren't crate_universe specific.

@google-cla google-cla bot added the cla: yes label Apr 27, 2021
@illicitonion illicitonion marked this pull request as draft April 27, 2021 17:43
.bazelci/presubmit.yml Outdated Show resolved Hide resolved
We already disable all sys crates from our tests, so this is keeping in
that fashion. Looks like the issues here aren't crate_universe specific.
@illicitonion illicitonion marked this pull request as ready for review April 28, 2021 13:23
@illicitonion illicitonion changed the title Try running on Windows Run basic crate_universe example on Windows Apr 28, 2021
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, forgot about the run files flag. Thanks!

@UebelAndre UebelAndre merged commit 4d4218b into bazelbuild:main Apr 28, 2021
@illicitonion illicitonion deleted the windows branch April 28, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants