Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape trailing backslashes in build script env vars #714

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Escape trailing backslashes in build script env vars #714

merged 1 commit into from
Apr 29, 2021

Conversation

illicitonion
Copy link
Collaborator

Fixes #710.

@google-cla google-cla bot added the cla: yes label Apr 29, 2021
hlopko
hlopko approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! (I'm back! :)

@illicitonion illicitonion merged commit feaeb7a into bazelbuild:main Apr 29, 2021
@illicitonion illicitonion deleted the trailing-newlines branch April 29, 2021 12:22
@dae
Copy link
Contributor

dae commented Apr 29, 2021

Thanks Daniel, appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlopko hlopko hlopko approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proc-macro-nested broken on Windows due to processwrapper env escaping
3 participants
@illicitonion @dae @hlopko