Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added environment variable to control downloading rustc sources #737

Merged
merged 2 commits into from
May 13, 2021

Conversation

UebelAndre
Copy link
Collaborator

This is a followup to a conversation from #733

rustc sources used in rust analyzer can now be conditionally included in toolchains using the RULES_RUST_TOOLCHAIN_INCLUDE_RUSTC_SRCS enviornment variable. Setting it to true or 1 will enable it and any other value will disable it. I feel this gives users the most flexibility in how the decide to enable/disable it locally or in CI.

Copy link
Member

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you! I'd give Daniel some time to take a look too.

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants