Add example of c calling rust #74
Conversation
|
Is the buildkite presubmit intended to not be publicly visible (with an account)? |
|
I think that's a design shortcoming. The detail page there lands on an administrative page. FWICT, you can see the build results without logging in. |
examples/ffi/c_calling_rust/BUILD
Outdated
| srcs = ["main.c"], | ||
| deps = [":wrapper"] | ||
| ) | ||
|
|
There was a problem hiding this comment.
Nit: Repo style is no extra newline (this file and rest)
| @@ -0,0 +1,20 @@ | |||
| load("@//rust:rust.bzl", "rust_library", "rust_test", "rust_binary") | |||
There was a problem hiding this comment.
Nit: Other examples have a visibility defined:
package(default_visibility = ["//visibility:public"])
There was a problem hiding this comment.
Should we weaken the rest of the examples' visibilities?
There was a problem hiding this comment.
I'm not excited about anyone depending on this or other examples
|
I didn't move the matrix example because I had already made changes to it in #61, I can follow suit in that pr |
mfarrugi
force-pushed
the
marco-c-calling-rust-example
branch
from
fd61799
to
8cbf0c5
Compare
|
Updated #61 to include "rust_calling_c" rename as well. |
|
@acmcarther Anything else for this one? |
|
LGTM, merging! |
Addresses #55.