Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include generated comment in docs #740

Merged
merged 2 commits into from
May 17, 2021
Merged

Conversation

alexeagle
Copy link
Contributor

This helps developers avoid accidentally sending PRs against generated content.
Based on upstream template https://github.com/bazelbuild/stardoc/blob/master/stardoc/templates/markdown_tables/header.vm

This helps developers avoid accidentally sending PRs against generated content.
Based on upstream template https://github.com/bazelbuild/stardoc/blob/master/stardoc/templates/markdown_tables/header.vm
@google-cla google-cla bot added the cla: yes label May 17, 2021
@UebelAndre
Copy link
Collaborator

Is there anything that checks for this comment or is this just a guide for contributors?

@alexeagle
Copy link
Contributor Author

On my docsite I use this to avoid duplicating content that I also generate

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Seems good to me 😄

@UebelAndre UebelAndre merged commit 971ff66 into bazelbuild:main May 17, 2021
@alexeagle
Copy link
Contributor Author

Thanks, I updated https://docs.aspect.dev/rules_rust with the latest

@UebelAndre
Copy link
Collaborator

@alexeagle just FYI, I'm getting a 404 on the links there. Not sure if that's just on my end though 😅
https://docs.aspect.dev/bazelbuild/rules_rust/eb06a7974f448b3a2199d490282906d698c2d316/docs/rust_fmt.md
Screen Shot 2021-05-17 at 2 00 29 PM

@alexeagle
Copy link
Contributor Author

Yeah thanks, I need to server-side redirect .md extension to .html
Netlify doesn't have that feature so I'm still working on it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants