Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings for //tools/rustfmt #745

Merged
merged 2 commits into from
May 18, 2021

Conversation

mypmc
Copy link
Contributor

@mypmc mypmc commented May 18, 2021

Close #744

//tools/rustfmt has been built successfully using following .bazelrc.

build --aspects=@rules_rust//rust:defs.bzl%rust_clippy_aspect
build --output_groups=+clippy_checks

@google-cla
Copy link

google-cla bot commented May 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 18, 2021
@mypmc
Copy link
Contributor Author

mypmc commented May 18, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels May 18, 2021
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion merged commit 61aafc3 into bazelbuild:main May 18, 2021
@mypmc mypmc deleted the fix-clippy-warnings branch May 18, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@rules_rust//tools/rustfmt fails to build
2 participants