-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crate_universe] Add README to examples/crate_universe
directory
#759
Conversation
To explain that `RULES_RUST_CRATE_UNIVERSE_BOOTSTRAP` environment variable must be set to `true` for examples to "just work." Also removes reference to `bootstrap.sh` from the `crate_universe/CONTRIBUTING.md` file since `bootstrap.sh` no longer exists
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR (and sorry our docs were out of date so you hit this problem!) - I've made a slight suggestion, as bootstrapping no longer generates a bazelrc file, then very happy to merge!
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Sounds good to me! |
Thanks! Would be very interested in any feedback/contributions you may have to |
This adds a README.md to the
examples/crate_universe
directory in order to explain that theRULES_RUST_CRATE_UNIVERSE_BOOTSTRAP
environment variablemust be set to
true
in order for the examples to "just work."It also removes reference to
bootstrap.sh
from thecrate_universe/CONTRIBUTING.md
file sincebootstrap.sh
no longer exists.