Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crate_universe] Add README to examples/crate_universe directory #759

Merged
merged 4 commits into from
May 30, 2021

Conversation

bcmyers
Copy link
Contributor

@bcmyers bcmyers commented May 29, 2021

This adds a README.md to the examples/crate_universe directory in order to explain that the RULES_RUST_CRATE_UNIVERSE_BOOTSTRAP environment variable
must be set to true in order for the examples to "just work."

It also removes reference to bootstrap.sh from the
crate_universe/CONTRIBUTING.md file since bootstrap.sh no longer exists.

To explain that `RULES_RUST_CRATE_UNIVERSE_BOOTSTRAP` environment variable
must be set to `true` for examples to "just work."

Also removes reference to `bootstrap.sh` from the
`crate_universe/CONTRIBUTING.md` file since `bootstrap.sh` no longer exists
@google-cla
Copy link

google-cla bot commented May 29, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 29, 2021
@bcmyers
Copy link
Contributor Author

bcmyers commented May 29, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels May 29, 2021
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR (and sorry our docs were out of date so you hit this problem!) - I've made a slight suggestion, as bootstrapping no longer generates a bazelrc file, then very happy to merge!

crate_universe/CONTRIBUTING.md Outdated Show resolved Hide resolved
crate_universe/CONTRIBUTING.md Outdated Show resolved Hide resolved
bcmyers and others added 2 commits May 29, 2021 20:15
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
@bcmyers
Copy link
Contributor Author

bcmyers commented May 30, 2021

Sounds good to me!

@illicitonion illicitonion merged commit f0875bc into bazelbuild:main May 30, 2021
@illicitonion
Copy link
Collaborator

Thanks! Would be very interested in any feedback/contributions you may have to crate_universe, as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants