Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added util module for rust repository rules. #773

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

UebelAndre
Copy link
Collaborator

I find it difficult to understand what the repository rules in //rust:repositories.bzl are doing with all the noise of the template BUILD files. This is a minor cleanup to make these rules and macros more readable.

@UebelAndre
Copy link
Collaborator Author

When I opened this PR I thought it'd just be the BUILD_* macros but turned out to be a bit more. I think it's still good cleanup but I can respect the argument that it's too much indirection (but I don't think this crosses a line).

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me :) I definitely agree that the file as-is is large and unwieldy!

@UebelAndre UebelAndre merged commit ca6043b into bazelbuild:main Jun 28, 2021
@UebelAndre UebelAndre deleted the util branch July 30, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants