Added standalone targets for rust_toolchain components.
#792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlopko
reviewed
Jun 28, 2021
UebelAndre
changed the title
toolchain_tool rule for fetching rust tools from a toolchainrust_toolchain components.
UebelAndre
force-pushed
the
tool
branch
10 times, most recently
from
ad4abc8
to
2b5a314
Compare
|
Windows is very unfun... but this PR is ready for review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if there's a better way to do this but I certainly feel it's better than:
rules_rust/tools/rustfmt/BUILD.bazel
Lines 7 to 16 in 8cb0c78
This PR adds targets for parsing specific components of a
rust_toolchain:@rules_rust//rust/toolchain:current_exec_rustfmt_files@rules_rust//rust/toolchain:current_exec_rustdoc_files@rules_rust//rust/toolchain:current_exec_rustc_srcs_files@rules_rust//rust/toolchain:current_exec_rustc_lib_files@rules_rust//rust/toolchain:current_exec_rustc_files@rules_rust//rust/toolchain:current_exec_rust_stdlib_files@rules_rust//rust/toolchain:current_exec_clippy_files@rules_rust//rust/toolchain:current_exec_cargo_filesThese targets give users the ability to consume these files at runtime (cargo-raze is also doing this and would benefit from these targets).