Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checksums for additional rust assets to internal list #794

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

UebelAndre
Copy link
Collaborator

I don't think we should be maintaining a separate list of revisions for rustfmt and I think it'd be useful to have additional artifact types being tracked:

  • cargo
  • clippy

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on board with the additions. I'm not so sure about the rustfmt piece - while I agree that now we don't need a separate list, before relatively recently (I would guess 1.48.0, from the contents of util/fetch_shas_RUSTFMT_VERSIONS.txt) rustfmt was versioned separately from the rest of the toolchain... I suspect this may break rustfmt support for pre-1.48.0 rust versions, because it will try to download files which don't exist?

@UebelAndre
Copy link
Collaborator Author

@illicitonion How would this break rustfmt support? The file I deleted was only used to determine what versions of rustfmt to query for. The fetch tool seems designed to allow for failures when something doesn't exist so the only change for rustfmt here is that we'll try to fetch more versions than there may be available. Nothing has changed about how users define what version of rustfmt they want.

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Sorry, I was mis-reading - thanks!

@UebelAndre UebelAndre merged commit 0768a7f into bazelbuild:main Jun 29, 2021
@UebelAndre UebelAndre deleted the shasum branch July 24, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants