Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added crate attribute to rustdoc rules (deprecated dep) #799

Merged
merged 4 commits into from
Jul 6, 2021

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Jun 25, 2021

In an effort to keep our naming conventions consistent, the crate attribute was added to the rustdoc rules.

Requires:

closes #512

@hlopko
Copy link
Member

hlopko commented Jun 28, 2021

As with #807, the diff here is too large for me to conveniently review. Could you either ping me once requirement PRs are merged, or (preferably) decouple this PR from the other 2? To the naive me it seems they are fairly independent?

@UebelAndre
Copy link
Collaborator Author

As with #807, the diff here is too large for me to conveniently review. Could you either ping me once requirement PRs are merged, or (preferably) decouple this PR from the other 2? To the naive me it seems they are fairly independent?

Just trying to avoid conflict resolution 😅 It is unrelated but I'd rather focus on one at a time to avoid extra work.

@UebelAndre UebelAndre merged commit dd1c73e into bazelbuild:main Jul 6, 2021
@UebelAndre UebelAndre deleted the rustdoc branch July 6, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider renaming rust_doc/rust_doc_test dep attr to crate, to match rust_test
3 participants