Add missing android extensions #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlopko
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
Could you add more info into the PR description? Things like is this a bug fix or a new behavior, how did you find it, why do you fix it, how did you test it.
I'll also say that in my world
Specify extensions for android system.
This is a drive-by fix. We don't currently have any android tests here and I didn't test it manually, but I think it's correct.
is an acceptable PR description :) It's better to be explicit.
Definitely, just trying to move a million miles an hour to get everything before bed time 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify extensions for android system.
This is a drive-by fix. We don't currently have any android tests here and I didn't test it manually, but I think it's correct.
(original conversation: #797 (comment))