Added rust_common.create_crate_info
#818
Merged
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlopko
reviewed
Jul 1, 2021
| rust_common = struct( | ||
| create_crate_info = _create_crate_info, |
There was a problem hiding this comment.
I know it's not exported to https://bazelbuild.github.io/rules_rust/, but could you also add a doc saying that create_crate_info should be used for construction, and crate_info for accessing?
There was a problem hiding this comment.
Like, a docstring? (like the one I added?)
There was a problem hiding this comment.
Oh right, yeah that works. Nit: rename "macro" to "function" in the docstring
There was a problem hiding this comment.
Is the terminology not "macro"? But updated.
hlopko
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rust_common.create_crate_infomacro creates aCrateInfoprovider through a macro which allows for the rules to maintain better backwards compatibility when making changes toCrateInfo.