Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export BAZEL_GENFILES_DIR and BAZEL_BIN_DIR at compilation. #82

Closed
wants to merge 1 commit into from
Closed

Export BAZEL_GENFILES_DIR and BAZEL_BIN_DIR at compilation. #82

wants to merge 1 commit into from

Conversation

SirVer
Copy link

@SirVer SirVer commented Apr 4, 2018

Fixes #79.

@acmcarther
Copy link
Collaborator

This is really appealing as a solution, but I'm afraid of unilaterally LGTMing it because it would be very hard to undo later.

Let me see if I can get @mhlopko for a one off analysis (this should be bitesized enough that he can look at it soonish).

@hlopko hlopko mentioned this pull request Apr 5, 2018
Closed
@SirVer
Copy link
Author

SirVer commented Apr 17, 2018

Closing this as we agree that it is not the right approach.

@SirVer SirVer closed this Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SirVer @acmcarther @googlebot