Added support for noclippy tag
#824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Jul 10, 2021
Merged
|
I ended up adding a regression test for this by enabling clippy in a |
illicitonion
approved these changes
Jul 10, 2021
There was a problem hiding this comment.
I'm slightly concerned that CI now doesn't test the default config without the extra aspects, and that we may accidentally introduce a dependency on the aspects at some point which shouldn't be there, but as we already have this for rustfmt, if we want to introduce a "no-aspect" CI pipeline that feels like a reasonable separate change for the future.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the rustfmt pattern of
norustfmtand allows users to opt out of running clippy on a particular target.