Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add incompatible flag for splitting rust_library #847

Merged
merged 8 commits into from
Jul 22, 2021
Merged

Add incompatible flag for splitting rust_library #847

merged 8 commits into from
Jul 22, 2021

Conversation

hlopko
Copy link
Member

@hlopko hlopko commented Jul 21, 2021

This PR adds some elementary infrastructure for incompatible flags.

@hlopko hlopko requested a review from UebelAndre July 21, 2021 07:59
@google-cla google-cla bot added the cla: yes label Jul 21, 2021
@hlopko hlopko requested a review from scentini July 21, 2021 07:59
@hlopko
Copy link
Member Author

hlopko commented Jul 21, 2021

Unsurprisingly, I realized the text of compatibility policy is incorrect. I'll update it once this PR is reviewed, once we settle down on things.

@hlopko hlopko changed the title Add incomaptible flag for splitting rust_library Add incompatible flag for splitting rust_library Jul 21, 2021
UebelAndre
UebelAndre previously requested changes Jul 21, 2021
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new rules will also need to be added to docs/symbols.bzl for them to show up in docs... lame to have this duplication, I know...

Otherwise, some small things but is looking good so far!

rust/settings/incompatible.bzl Outdated Show resolved Hide resolved
rust/settings/incompatible.bzl Outdated Show resolved Hide resolved
rust/settings/incompatible.bzl Outdated Show resolved Hide resolved
hlopko
hlopko commented Jul 22, 2021
View reviewed changes
Copy link
Member Author

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new rules will also need to be added to docs/symbols.bzl for them to show up in docs... lame to have this duplication, I know...

Done. Please take another look :)

rust/settings/incompatible.bzl Outdated Show resolved Hide resolved
rust/settings/incompatible.bzl Outdated Show resolved Hide resolved
rust/settings/incompatible.bzl Outdated Show resolved Hide resolved
@hlopko hlopko mentioned this pull request Jul 22, 2021
Merged
UebelAndre
UebelAndre approved these changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me! Just needs to look good to buildifier now 😄

@UebelAndre UebelAndre merged commit ce8005c into bazelbuild:main Jul 22, 2021
@hlopko hlopko deleted the incompatible.bzl branch July 23, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre approved these changes

@scentini scentini Awaiting requested review from scentini

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hlopko @UebelAndre